smengcl commented on code in PR #5301:
URL: https://github.com/apache/ozone/pull/5301#discussion_r1338282488
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -1815,6 +1818,16 @@ message SnapshotPurgeRequest {
repeated string updatedSnapshotDBKey = 2;
}
+message SetSnapshotPropertyRequest {
+ repeated SnapshotProperty snapshotProperty = 1;
Review Comment:
@hemantk-12
For error handling, the caller has to handle any error in the response
carefully when some of the requests failed and some succeeded.
Performance wise I'd say we just need to count the metrics in finer
granularity. For a `SetSnapshotPropertyRequest` that contains 100 snapshot
updates, the metric could be increased by 100 rather than 1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
