hemantk-12 commented on code in PR #5301:
URL: https://github.com/apache/ozone/pull/5301#discussion_r1338873792
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -1815,6 +1818,16 @@ message SnapshotPurgeRequest {
repeated string updatedSnapshotDBKey = 2;
}
+message SetSnapshotPropertyRequest {
+ repeated SnapshotProperty snapshotProperty = 1;
Review Comment:
@smengcl
* My concern is on server side error handling, e.g. in
[OMSnapshotSetPropertyRequest](https://github.com/apache/ozone/pull/5301/files#diff-cd87e80aa08edcaf38ee47c0d14820c15419b28e39eed9a0167d4a86db51e76dR87)
and
[OMSnapshotPurgeRequest](https://github.com/apache/ozone/blob/eec1ce49c87595c83d6946c019c24bda4e86401d/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/snapshot/OMSnapshotPurgeRequest.java#L95)
is something fails in the loop, it will be partially updated. It won't be a
problem if we handle each entry individually.
* Regarding performance, it is not just about request count metric, that is
easier compare to latency and failure metrics. E.g. latency for a batch of 1000
would be different that a batch of 1 or 2. You can argue that we can use avg
but it won't give correct picture.
Again, as I said earlier these concerns might not be valid in this case
because this API will be used by internal [KeyDeletingService] only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
