aswinshakil commented on code in PR #5301:
URL: https://github.com/apache/ozone/pull/5301#discussion_r1337587656
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/KeyDeletingService.java:
##########
@@ -88,6 +93,9 @@ public class KeyDeletingService extends
AbstractKeyDeletingService {
private final int keyLimitPerTask;
private final AtomicLong deletedKeyCount;
private final AtomicBoolean suspended;
+ private final Map<String, Long> exclusiveSizeList;
+ private final Map<String, Long> exclusiveReplicatedSizeList;
+ private final Set<String> completedExclusiveSizeList;
Review Comment:
The reason for keeping it global is because of the `keyLimitPerTask`. At a
time it is not guaranteed the entire snapshot is processed, If we keep it local
it will be cleared in the next iteration. I will be doing a follow-up PR, where
we will be continuing size calculation from where we stopped during the
pervious iteration because of `keyLimitPerTask`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
