aswinshakil commented on PR #5301: URL: https://github.com/apache/ozone/pull/5301#issuecomment-1736010194
Thanks for the review @hemantk-12 I will be updating the PR shortly with the suggestions. For the questions, 1. Correct. The last snapshot will not have exclusive size. For the last snapshot, we should calculate it using Active DB's `deletedTable`. The Active DB is constantly changing and we would be iterating through the `deletedTable` every time the `KeyDeletingService` runs, This takes hold of `deletedTable` lock and we will be constantly holding this lock even though there is nothing to update it. 2. Yes, It will be eventually calculated. Not immediately when the snapshot is taken. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
