sadanand48 commented on code in PR #5445:
URL: https://github.com/apache/ozone/pull/5445#discussion_r1377158971
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerDoubleBuffer.java:
##########
@@ -285,6 +295,8 @@ private void addToBatchTransactionInfoWithTrace(String
parentName,
void flushTransactions() {
while (isRunning.get() && canFlush()) {
flushCurrentBuffer();
+ // Invalidate all the content in S3SecretManager cache.
+ s3SecretManager.clearS3Cache();
Review Comment:
We cannot just simply cleanup all entries at once, only the committed
transactions need to be cleaned up. RocksDb table cache uses trxLogIndex as an
epoch for the cache entry.
Refer to cleanup cache method in this class. The idea is to track the
committed trxs and only remove those from the cache.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
