szetszwo commented on PR #921:
URL: https://github.com/apache/ozone/pull/921#issuecomment-1843486199
@anuengineer , the problem is simple -- do you think the code below is easy
to read?
```java
//StorageContainerManager.java
FixedThreadPoolWithAffinityExecutor<IncrementalContainerReportFromDatanode,
ContainerReport> incrementalReportExecutors =
new FixedThreadPoolWithAffinityExecutor<>(
EventQueue.getExecutorName(
SCMEvents.INCREMENTAL_CONTAINER_REPORT,
incrementalContainerReportHandler),
incrementalContainerReportHandler, queues, eventQueue,
IncrementalContainerReportFromDatanode.class, executors,
reportExecutorMap);
```
Code may have large indentation and long names such as
`IncrementalContainerReportFromDatanode`. This is very different from English.
Short line length is really hurt productivity!
```java
public static void main(String[] args) {
final String s = "IncrementalContainerReportFromDatanode";
System.out.println(s + ": length=" + s.length());
}
// Output:
// IncrementalContainerReportFromDatanode: length=38
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
