adoroszlai commented on PR #921: URL: https://github.com/apache/ozone/pull/921#issuecomment-1843585433
> Concise answer is that shape of code -- has meaning. The layout implies meaning and is the core artifact in comprehension. It is not line wrap, it is about crafting meaning in certain lay and text layout influences that. @anuengineer I couldn't agree more. However, meaningful layout cannot be crafted in all cases with the current limit. Many times you are forced to break the natural flow at arbitrary locations. These unnatural breaks make code more difficult to understand. The same point is clearly made in the [article](https://optimal-codestyle.github.io/#line-length) you [referenced](https://github.com/apache/ozone/pull/921#issuecomment-807589456) 2.5 years ago in this thread: > The need to form an adequate visual representation of the logical structure of the program leads to the fact that such a formal restriction for the program text in many cases can, on the contrary, worsen the readability of the program. > > Lines of program text are not so strictly bound to the left edge and are often indented to display the appropriate level of hierarchy in its structure. The breakdown of expression by lines should be based on the best representation of their internal structure and in the context of the structure of the code, which they are part. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
