sodonnel commented on PR #5651: URL: https://github.com/apache/ozone/pull/5651#issuecomment-1846963602
> I've updated ContainerHealthStatus to use RatisContainerReplicaCount for calculating over-replication or under-replication. This seems like a good idea. However, what about EC containers? They will have the same problems, and there is an EcContainerReplicaCount class too. I see in `getMinimumRequiredReplicaNum` you are checking for EC or Ratis, so you also need to check for EC or Ratis and create the correct ReplicaCount object for EC or Ratis. Another question - what does Recon do to the container replicas it knows about when a maintenance node goes offline? Does it purge them from memory, or keep them? What does recon do when an IN_SERVICE node goes dead, does it keep the replicas in memory marked as dead or does it just remove them like SCM does? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
