ChenSammi commented on code in PR #5783:
URL: https://github.com/apache/ozone/pull/5783#discussion_r1429721477
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/ContainerStateMachine.java:
##########
@@ -403,16 +416,32 @@ public TransactionContext
startTransaction(RaftClientRequest request)
.setStateMachineData(write.getData())
.setLogData(commitContainerCommandProto.toByteString())
.build();
- } else {
- return TransactionContext.newBuilder()
+ } else if (proto.getCmdType() == Type.FinalizeBlock) {
+ containerController.addFinalizedBlock(proto.getContainerID(),
Review Comment:
We cannot add the finalize block in startTransaction, otherwise there is
chance that valid write chunk or put block in applyTransaction will be failed
because of this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
