ashishkumar50 commented on code in PR #5783:
URL: https://github.com/apache/ozone/pull/5783#discussion_r1432593427
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/metadata/DatanodeSchemaThreeDBDefinition.java:
##########
@@ -92,14 +93,25 @@ public class DatanodeSchemaThreeDBDefinition
DeletedBlocksTransaction.class,
Proto2Codec.get(DeletedBlocksTransaction.class));
+ public static final DBColumnFamilyDefinition<String, FinalizeBlockList>
+ FINALIZE_BLOCKS =
+ new DBColumnFamilyDefinition<>(
+ "finalize_blocks",
+ String.class,
+ FixedLengthStringCodec.get(),
+ FinalizeBlockList.class,
+ FinalizeBlockList.getCodec());
+
Review Comment:
I have changed storage as <ContainerId | LocalId, BlockData>. Since
DatanodeTable
[iterator](https://github.com/apache/ozone/blob/be2e19948b6c8fb3f3b9a0c69ee6dfd88967f840/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/metadata/DatanodeTable.java#L80)
doesn't support. I store value as BlockData and currently used
[keyValueBlockIterator](https://github.com/apache/ozone/blob/be2e19948b6c8fb3f3b9a0c69ee6dfd88967f840/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/metadata/AbstractDatanodeStore.java#L287)
which can iterate through blocks. Is this fine to store or do you have any
other suggestion?
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java:
##########
@@ -1160,6 +1205,15 @@ public void closeContainer(Container container)
.getContainerID() + " while in " + state + " state.", error);
}
container.close();
+
+ KeyValueContainerData containerData =
Review Comment:
Moved inside contianer.close()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
