ashishkumar50 commented on code in PR #5783:
URL: https://github.com/apache/ozone/pull/5783#discussion_r1432584337
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueContainerData.java:
##########
@@ -384,6 +413,10 @@ public String getDeletingBlockKeyPrefix() {
return formatKey(DELETING_KEY_PREFIX);
}
+ public String getFinalizeBlockKey() {
+ return formatKey("");
Review Comment:
I wanted to keep only containerId as key,
[formatKey](https://github.com/apache/ozone/blob/cd0c55e4ffa879b3e7cffe182237f0e1c824a7c0/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueContainerData.java#L429)
returns key as containerId in v3, so that would work.
But because of this
[comment](https://github.com/apache/ozone/pull/5783#discussion_r1429729146),
changed now key format to use containerId|localID
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/helpers/KeyValueContainerUtil.java:
##########
@@ -365,6 +367,20 @@ private static void populateContainerMetadata(
ContainerInspectorUtil.process(kvContainerData, store);
}
+ private static void populateContainerFinalizeBlock(
+ KeyValueContainerData kvContainerData, DatanodeStore store)
+ throws IOException {
+ Table<String, FinalizeBlockList> finalizeBlocksTable =
+ store.getFinalizeBlocksTable();
+
+ FinalizeBlockList finalizeBlockList =
+ finalizeBlocksTable.get(kvContainerData.getFinalizeBlockKey());
Review Comment:
It would have loaded only container specific list as based on previous
comment format key returns containerId as key in schema v3. Now i have changed
key structure as previous comment..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
