ChenSammi commented on code in PR #5783:
URL: https://github.com/apache/ozone/pull/5783#discussion_r1429729146
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/metadata/DatanodeSchemaThreeDBDefinition.java:
##########
@@ -92,14 +93,25 @@ public class DatanodeSchemaThreeDBDefinition
DeletedBlocksTransaction.class,
Proto2Codec.get(DeletedBlocksTransaction.class));
+ public static final DBColumnFamilyDefinition<String, FinalizeBlockList>
+ FINALIZE_BLOCKS =
+ new DBColumnFamilyDefinition<>(
+ "finalize_blocks",
+ String.class,
+ FixedLengthStringCodec.get(),
+ FinalizeBlockList.class,
+ FinalizeBlockList.getCodec());
+
Review Comment:
Please don't use list as value here. The list will have performance impact.
For example, if there is 99 blocks already, then the 100th block comes, we need
to persist the whole list with 100 elements in to RocksDB, the list introduces
unnecessary bytes to write.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
