ashishkumar50 commented on code in PR #5783:
URL: https://github.com/apache/ozone/pull/5783#discussion_r1432614444
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/ContainerStateMachine.java:
##########
@@ -403,16 +416,32 @@ public TransactionContext
startTransaction(RaftClientRequest request)
.setStateMachineData(write.getData())
.setLogData(commitContainerCommandProto.toByteString())
.build();
- } else {
- return TransactionContext.newBuilder()
+ } else if (proto.getCmdType() == Type.FinalizeBlock) {
+ containerController.addFinalizedBlock(proto.getContainerID(),
Review Comment:
We are rejecting request only in `startTransaction` and not in
`applyTransaction`. So once the request has passed in startTransaction I think
it should succeed in `applyTransaction.` In which case this can happen?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
