ChenSammi commented on code in PR #5783:
URL: https://github.com/apache/ozone/pull/5783#discussion_r1433861080
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/helpers/KeyValueContainerUtil.java:
##########
@@ -365,6 +367,23 @@ private static void populateContainerMetadata(
ContainerInspectorUtil.process(kvContainerData, store);
}
+ private static void populateContainerFinalizeBlock(
+ KeyValueContainerData kvContainerData, DatanodeStore store)
+ throws IOException {
+ List<Long> lstLocalId = new ArrayList<>();
+
+ try (BlockIterator<BlockData> iter =
+ store.getFinalizeBlockIterator(kvContainerData.getContainerID(),
+ kvContainerData.getContainerPrefixFilter())) {
+ while (iter.hasNext()) {
+ lstLocalId.add(iter.nextBlock().getLocalID());
Review Comment:
Why not add the local ID to kvContainerData directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
