errose28 commented on code in PR #6919:
URL: https://github.com/apache/ozone/pull/6919#discussion_r1672533762
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/OMBucketCreateRequest.java:
##########
@@ -460,7 +460,7 @@ public static OMRequest
handleCreateBucketWithBucketLayoutDuringPreFinalize(
* they do not understand.
*/
@RequestFeatureValidator(
- conditions = ValidationCondition.OLDER_CLIENT_REQUESTS,
+ conditions = ValidationCondition.OLDER_BUCKET_LAYOUT_CLIENT_REQUESTS,
Review Comment:
Rejection does not happen in the annotation. The annotation determines when
the method should be called. In this case this method is called when we get an
older client request. That's why the method to check the condition is called
[shouldApply](https://github.com/apache/ozone/blob/74d92c86be579e6d90535a13a276e1970ac644fc/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/validation/ValidationCondition.java#L49).
The body of the method determines whether to reject or modify the request. The
body of the method has a more specific check for specific client version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
