errose28 commented on PR #6919: URL: https://github.com/apache/ozone/pull/6919#issuecomment-2220864893
> Yes this part worked but if you check, lines like [these](https://github.com/apache/ozone/blob/4d29b6ce30019fb9b47d5f1a4a88645214cf23b9/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerRequestHandler.java#L663) ,it would fail. We need proper coverage of tests to detect if all API's are compatible but based on what I checked , the current change must take care of most cases. Ok so it looks like the conditional in the body was missed for some requests. That is the proper fix. Ideally all the params should be specified in the annotation but that is an API change that should be its own issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
