swamirishi commented on code in PR #6919:
URL: https://github.com/apache/ozone/pull/6919#discussion_r1672542968


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/validation/ValidationCondition.java:
##########
@@ -42,12 +42,13 @@ public boolean shouldApply(OMRequest req, ValidationContext 
ctx) {
 
   /**
    * Classifies validations that has to run, when the client uses an older
-   * protocol version than the server.
+   * protocol version than the bucket layout version i.e the version where
+   * bucket types where introduced.
    */
-  OLDER_CLIENT_REQUESTS {
+  OLDER_BUCKET_LAYOUT_CLIENT_REQUESTS {

Review Comment:
   @errose28 This fixes the issue.



##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/OMBucketCreateRequest.java:
##########
@@ -460,7 +460,7 @@ public static OMRequest 
handleCreateBucketWithBucketLayoutDuringPreFinalize(
    * they do not understand.
    */
   @RequestFeatureValidator(
-      conditions = ValidationCondition.OLDER_CLIENT_REQUESTS,
+      conditions = ValidationCondition.OLDER_BUCKET_LAYOUT_CLIENT_REQUESTS,

Review Comment:
   @errose28 it happens here 
https://github.com/apache/ozone/blob/74d92c86be579e6d90535a13a276e1970ac644fc/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/validation/ValidationCondition.java#L50



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to