sadanand48 commented on PR #6919: URL: https://github.com/apache/ozone/pull/6919#issuecomment-2220969002
> The current PR implementation is not good because for each client version added, you also need to add a new condition in a different enum In my defense, prior to this change, the enum OLDER_CLIENT_REQUESTS was only used in the context of bucket layout based validations so the rename seemed convenient and easy. However I agree that we can add the additional condition in the all methods uniformly to maintain consistent behaviour. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
