errose28 commented on code in PR #6919:
URL: https://github.com/apache/ozone/pull/6919#discussion_r1672592954
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/OMBucketCreateRequest.java:
##########
@@ -460,7 +460,7 @@ public static OMRequest
handleCreateBucketWithBucketLayoutDuringPreFinalize(
* they do not understand.
*/
@RequestFeatureValidator(
- conditions = ValidationCondition.OLDER_CLIENT_REQUESTS,
+ conditions = ValidationCondition.OLDER_BUCKET_LAYOUT_CLIENT_REQUESTS,
Review Comment:
I agree. I also [suggested a
refactor](https://github.com/apache/ozone/pull/6919#pullrequestreview-2169483573),
but in a follow up. The refactor done here is not good because it requires
updates to two enums for each client layout version.
> Ideally all the compat requirements would be specified in the annotation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
