sundapeng commented on code in PR #10303:
URL: https://github.com/apache/paimon/pull/10303#discussion_r4191015219
##########
paimon-core/src/main/java/org/apache/paimon/table/format/SplitEnumerator.java:
##########
@@ -154,12 +152,28 @@ List<Split> createSplits(
@Nullable BinaryRow partition,
boolean useCatalogContextFileIO)
throws IOException {
+ return createSplits(
Review Comment:
Better to merge into the existing constructor.
##########
paimon-core/src/main/java/org/apache/paimon/table/format/FormatDataSplit.java:
##########
@@ -40,16 +40,26 @@ public class FormatDataSplit implements Split {
private final List<FileMeta> files;
@Nullable private final BinaryRow partition;
private final boolean useCatalogContextFileIO;
+ @Nullable private final String fileFormat;
public FormatDataSplit(List<FileMeta> files, @Nullable BinaryRow
partition) {
this(files, partition, false);
}
public FormatDataSplit(
Review Comment:
Better to merge into the existing constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
