tonymtu commented on code in PR #10303:
URL: https://github.com/apache/paimon/pull/10303#discussion_r4191188571


##########
paimon-core/src/main/java/org/apache/paimon/table/format/SplitEnumerator.java:
##########
@@ -154,12 +152,28 @@ List<Split> createSplits(
             @Nullable BinaryRow partition,
             boolean useCatalogContextFileIO)
             throws IOException {
+        return createSplits(

Review Comment:
   Merged the forwarding overload in abc153036.



##########
paimon-core/src/main/java/org/apache/paimon/table/format/FormatDataSplit.java:
##########
@@ -40,16 +40,26 @@ public class FormatDataSplit implements Split {
     private final List<FileMeta> files;
     @Nullable private final BinaryRow partition;
     private final boolean useCatalogContextFileIO;
+    @Nullable private final String fileFormat;
 
     public FormatDataSplit(List<FileMeta> files, @Nullable BinaryRow 
partition) {
         this(files, partition, false);
     }
 
     public FormatDataSplit(
             List<FileMeta> files, @Nullable BinaryRow partition, boolean 
useCatalogContextFileIO) {
+        this(files, partition, useCatalogContextFileIO, null);

Review Comment:
   I kept the existing public constructor as a one-line delegate to preserve 
source and binary compatibility for external callers. Initialization remains in 
the four-argument constructor.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to