gokceni commented on a change in pull request #735: PHOENIX-5734 -
IndexScrutinyTool should not report rows beyond maxLoo…
URL: https://github.com/apache/phoenix/pull/735#discussion_r394609771
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexScrutinyMapper.java
##########
@@ -161,12 +168,22 @@ protected void setup(final Context context) throws
IOException, InterruptedExcep
LOGGER.info("Target table base query: " + targetTableQuery);
md5 = MessageDigest.getInstance("MD5");
ttl = getTableTtl();
+ maxLookbackAgeMillis =
ScanInfoUtil.getMaxLookbackInMillis(configuration);
} catch (SQLException | NoSuchAlgorithmException e) {
tryClosingResourceSilently(this.outputUpsertStmt);
tryClosingResourceSilently(this.connection);
tryClosingResourceSilently(this.outputConn);
throw new RuntimeException(e);
}
+ postSetup();
+ }
+
+ protected void preSetup() {
Review comment:
Any reasons to have these empty methods?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
