priyankporwal commented on a change in pull request #735: PHOENIX-5734 -
IndexScrutinyTool should not report rows beyond maxLoo…
URL: https://github.com/apache/phoenix/pull/735#discussion_r395862690
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/PhoenixScrutinyJobCounters.java
##########
@@ -41,5 +41,11 @@
/**
* Number of batches processed
*/
- BATCHES_PROCESSED_COUNT;
+ BATCHES_PROCESSED_COUNT,
+ /**
+ * Number of rows in source that became older than the max lookback age
while scrutiny
+ * was comparing them with the target, and didn't match. We break these
out separately because
+ * they could be due to extra versions being compacted, and are harmless.
+ */
+ BEYOND_MAX_LOOKBACK;
Review comment:
All counters end with '_COUNT' here ... Perhaps we should remain consistent.
That said, 'BEYOND_MAX_LOOKBACK_ROW_COUNT' looks too long. How about
'NO_LOOKBACK_ROW_COUNT'?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
