gjacoby126 commented on a change in pull request #735: PHOENIX-5734 -
IndexScrutinyTool should not report rows beyond maxLoo…
URL: https://github.com/apache/phoenix/pull/735#discussion_r394672881
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexScrutinyTool.java
##########
@@ -505,6 +509,18 @@ public int run(String[] args) throws Exception {
}
}
+ private void validateTimestamp(Configuration configuration, long ts) {
+ long maxLookBackAge =
ScanInfoUtil.getMaxLookbackInMillis(configuration);
+ if (maxLookBackAge != ScanInfoUtil.DEFAULT_PHOENIX_MAX_LOOKBACK_AGE *
1000L) {
Review comment:
The default age is the same as "turn off max lookback". It happens to be 0,
which makes the 1000L not necessary, but I wanted to keep the discipline of
_always_ converting to millis from seconds to avoid accidentally missing it
elsewhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
