gjacoby126 commented on a change in pull request #735: PHOENIX-5734 -
IndexScrutinyTool should not report rows beyond maxLoo…
URL: https://github.com/apache/phoenix/pull/735#discussion_r395303792
##########
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/MaxLookbackIT.java
##########
@@ -317,16 +300,16 @@ public void testRecentMaxVersionsNotCompactedAway()
throws Exception {
//after flush, check to make sure we can see all three versions at
the appropriate times
assertMultiVersionLookbacks(dataTableSelectSql, allValues,
allSCNs);
assertMultiVersionLookbacks(indexTableSelectSql, allValues,
allSCNs);
- majorCompact(dataTable,
EnvironmentEdgeManager.currentTimeMillis());
- majorCompact(indexTable,
EnvironmentEdgeManager.currentTimeMillis());
+ majorCompact(dataTable);
+ majorCompact(indexTable);
//after major compaction, check to make sure we can see all three
versions
// at the appropriate times
assertMultiVersionLookbacks(dataTableSelectSql, allValues,
allSCNs);
assertMultiVersionLookbacks(indexTableSelectSql, allValues,
allSCNs);
injectEdge.incrementValue(MAX_LOOKBACK_AGE * 1000);
long afterLookbackAgeSCN =
EnvironmentEdgeManager.currentTimeMillis();
- majorCompact(dataTable, afterLookbackAgeSCN);
- majorCompact(indexTable, afterLookbackAgeSCN);
+ majorCompact(dataTable);
+ majorCompact(indexTable);
Review comment:
First, this test suite only was modified because I needed to steal its major
compaction code and put it into TestUtil. It's otherwise unrelated to this
JIRA, and if it needs changes, that should be a separate issue.
Second, this isn't really a test of indexing per se, but of whether the max
lookback coproc hooks correctly prevent data from being purged during the
lookback window.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
