gjacoby126 commented on a change in pull request #735: PHOENIX-5734 -
IndexScrutinyTool should not report rows beyond maxLoo…
URL: https://github.com/apache/phoenix/pull/735#discussion_r394674341
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexScrutinyMapper.java
##########
@@ -288,8 +301,15 @@ protected void checkIfInvalidRowsExpired(Context context,
Pair<Long, List<Object>> sourceValues = entry.getValue();
Long sourceTS = sourceValues.getFirst();
if (hasRowExpiredOnSource(sourceTS, ttl)) {
-
context.getCounter(PhoenixScrutinyJobCounters.EXPIRED_ROW_COUNT).increment(1);
- itr.remove();
+
context.getCounter(PhoenixScrutinyJobCounters.EXPIRED_ROW_COUNT).increment(1L);
+ itr.remove(); //don't output to the scrutiny table
+ } else if (isRowOlderThanMaxLookback(sourceTS)){
+
context.getCounter(PhoenixScrutinyJobCounters.BEYOND_MAX_LOOKBACK).increment(1L);
+ //still output to the scrutiny table just in case it's useful
Review comment:
Humans need to evaluate beyond max lookback counters to see if they're valid
issues or not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
