eric-maynard commented on code in PR #376:
URL: https://github.com/apache/polaris/pull/376#discussion_r1802374450


##########
polaris-service/src/main/java/org/apache/polaris/service/admin/PolarisAdminService.java:
##########
@@ -533,6 +534,24 @@ private boolean 
catalogOverlapsWithExistingCatalog(CatalogEntity catalogEntity)
             });
   }
 
+  private boolean catalogLocationsContainWasb(CatalogEntity catalogEntity) {

Review Comment:
   Quite a thin method and only used in one place. If we are going to make it 
its own method, can we at least make it more visible to test it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to