eric-maynard commented on code in PR #376:
URL: https://github.com/apache/polaris/pull/376#discussion_r1803520107
##########
polaris-core/src/main/java/org/apache/polaris/core/PolarisConfiguration.java:
##########
@@ -191,4 +191,12 @@ public static <T> Builder<T> builder() {
"If set to true, allows tables to be dropped with the purge
parameter set to true.")
.defaultValue(true)
.build();
+
+ public static final PolarisConfiguration<Boolean> SUPPORT_WASB_CATALOG =
Review Comment:
I think we probably should support it. Indeed, don't we already block `http`
paths?
Also, why is this specified to catalog creation? The approach here just
seems very specific to me.
##########
polaris-core/src/main/java/org/apache/polaris/core/PolarisConfiguration.java:
##########
@@ -191,4 +191,12 @@ public static <T> Builder<T> builder() {
"If set to true, allows tables to be dropped with the purge
parameter set to true.")
.defaultValue(true)
.build();
+
+ public static final PolarisConfiguration<Boolean> SUPPORT_WASB_CATALOG =
Review Comment:
I think we probably should support it. Indeed, don't we already block `http`
paths?
Also, why is this specific to catalog creation? The approach here just seems
very specific to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
