collado-mike commented on code in PR #376:
URL: https://github.com/apache/polaris/pull/376#discussion_r1803484739
##########
polaris-core/src/main/java/org/apache/polaris/core/PolarisConfiguration.java:
##########
@@ -191,4 +191,12 @@ public static <T> Builder<T> builder() {
"If set to true, allows tables to be dropped with the purge
parameter set to true.")
.defaultValue(true)
.build();
+
+ public static final PolarisConfiguration<Boolean> SUPPORT_WASB_CATALOG =
Review Comment:
I don't know that we need to extend this configuration to support `s3n`,
etc. I _do_ think we could push the check into the `StorageLocation` class so
that it can be responsible for tracking which scheme(s) it supports and which
should be rejected at creation. So, e.g., the `AzureLocation` class can
implement a `canCreateNew()` method or something and it can, internally,
determine whether `wasb` is supported or not. Some future `S3StorageLocation`
can track `s3x` URLs, though AFAIK there's no reason to explicitly add/deny
support for any of those variations are supported by the existing Iceberg
`S3FileIO`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
