eric-maynard commented on code in PR #376:
URL: https://github.com/apache/polaris/pull/376#discussion_r1802387834
##########
polaris-core/src/main/java/org/apache/polaris/core/PolarisConfiguration.java:
##########
@@ -191,4 +191,12 @@ public static <T> Builder<T> builder() {
"If set to true, allows tables to be dropped with the purge
parameter set to true.")
.defaultValue(true)
.build();
+
+ public static final PolarisConfiguration<Boolean> SUPPORT_WASB_CATALOG =
Review Comment:
I actually thought that test with the two `DropwizardAppExtension` was
pretty good given what we have now. The suggestion you made for an annotation
sounds great, but I definitely don't think that's a blocker for this PR.
My comment here is specifically about having a single boolean config
specific to WASB (+WASBS) and how that doesn't scale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
