tzuan16 commented on code in PR #376:
URL: https://github.com/apache/polaris/pull/376#discussion_r1802383388
##########
polaris-core/src/main/java/org/apache/polaris/core/PolarisConfiguration.java:
##########
@@ -191,4 +191,12 @@ public static <T> Builder<T> builder() {
"If set to true, allows tables to be dropped with the purge
parameter set to true.")
.defaultValue(true)
.build();
+
+ public static final PolarisConfiguration<Boolean> SUPPORT_WASB_CATALOG =
Review Comment:
Agree that the current approach is not at all extensible. I was hoping we
have a test annotation like `@WithConfig(configName="true")` that could
directly modify the config store, but that would require a larger test
framework change that would fall out of scope of this PR. Currently the config
store only contains getter methods and there's also no way to modify its
content via code via a setter method, so I had to proceed with this pattern of
initiating two `DropwizardAppExtension` instances.
Do you think we could wait until the test framework to be more interactable
with the config store that we refactor this test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
