dimas-b commented on code in PR #2012:
URL: https://github.com/apache/polaris/pull/2012#discussion_r2207846885
##########
spec/polaris-management-service.yml:
##########
@@ -1056,6 +1056,12 @@ components:
type: string
description: endpoint for STS requests (optional). If not set,
defaults to 'endpoint'.
example: "https://sts.example.com:1234";
+ pathStyleAccess:
+ type: boolean
+ description: >-
+ Whether S3 requests to files in this catalog should use
'path-style addressing for buckets'.
+ Default: false.
Review Comment:
If we add a `default` declaration in the Open API YAML, then the Open API
generators will produce API-level classes in a way that will _always_ put the
`pathStyleAccess` attribute into JSON responses.
My changes in this PR specifically avoid that situation to ensure "no
behaviour" change in existing servers.
I personally think that this kind of backward-compatibility guarantee is
preferable to adding a `default` declaration to the Open API YAML.
@eric-maynard : what benefit do you see in having `default` in Open API YAML?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
