eric-maynard commented on code in PR #2012:
URL: https://github.com/apache/polaris/pull/2012#discussion_r2208001933
##########
spec/polaris-management-service.yml:
##########
@@ -1056,6 +1056,12 @@ components:
type: string
description: endpoint for STS requests (optional). If not set,
defaults to 'endpoint'.
example: "https://sts.example.com:1234";
+ pathStyleAccess:
+ type: boolean
+ description: >-
+ Whether S3 requests to files in this catalog should use
'path-style addressing for buckets'.
+ Default: false.
Review Comment:
> I personally think that this kind of backward-compatibility guarantee is
preferable to adding a default declaration to the Open API YAML.
This is the crux of the debate here, I guess. I don't see why that's
preferable.
> what benefit do you see in having default in Open API YAML?
Besides consistency with the rest of the spec(s), it seems intuitive that we
should use the `default` feature to make a `default`. This could, for example,
help generated clients populate the correct value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
