dimas-b commented on code in PR #2012:
URL: https://github.com/apache/polaris/pull/2012#discussion_r2208446588
##########
spec/polaris-management-service.yml:
##########
@@ -1056,6 +1056,12 @@ components:
type: string
description: endpoint for STS requests (optional). If not set,
defaults to 'endpoint'.
example: "https://sts.example.com:1234";
+ pathStyleAccess:
+ type: boolean
+ description: >-
+ Whether S3 requests to files in this catalog should use
'path-style addressing for buckets'.
+ Default: false.
Review Comment:
> the new field also appears if you create new a catalog using the PR as-is
Not quite. If you do not set the new fields in a new catalog, they will not
appear in REST responses.
This is the key point from my POV. We delegate behaviour changes to the user
/ admin of the catalog as opposed to forcing all clients to deal with the
default value of the new attribute even if there catalogs do not have to set it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
