dimas-b commented on code in PR #2012:
URL: https://github.com/apache/polaris/pull/2012#discussion_r2208620579
##########
spec/polaris-management-service.yml:
##########
@@ -1056,6 +1056,12 @@ components:
type: string
description: endpoint for STS requests (optional). If not set,
defaults to 'endpoint'.
example: "https://sts.example.com:1234";
+ pathStyleAccess:
+ type: boolean
+ description: >-
+ Whether S3 requests to files in this catalog should use
'path-style addressing for buckets'.
+ Default: false.
Review Comment:
> If clients fail on unknown properties, it's a bug in those client.
While I agree with this statement, I do not think Polaris should aggravate
this situation, where we can avoid it (i.e. no using `default`).
In other words, I'm proposing to take a more lenient approach. Not providing
a value for `pathStyleAccess` when creating a catalog does not alter (old)
Polaris catalog behaviour and is not even visible to clients (old or new). The
Polaris Server behaviour in this case is equivalent to having the default value
for `pathStyleAccess`, yet we get the benefit of broader client compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
