eric-maynard commented on code in PR #2012:
URL: https://github.com/apache/polaris/pull/2012#discussion_r2208538873
##########
spec/polaris-management-service.yml:
##########
@@ -1056,6 +1056,12 @@ components:
type: string
description: endpoint for STS requests (optional). If not set,
defaults to 'endpoint'.
example: "https://sts.example.com:1234";
+ pathStyleAccess:
+ type: boolean
+ description: >-
+ Whether S3 requests to files in this catalog should use
'path-style addressing for buckets'.
+ Default: false.
Review Comment:
> But why yield the default value of a field at all? The default for a
boolean is false, also the meaning of "not present" is also false.
This depends on whether you expect the client or the server to interpret
"not present". If the client thinks the server is handling it (i.e. never
sending "not present") and the server thinks the client is handling it, you
have a problem. To resolve this ambiguity, OpenAPI supports adding a default to
the spec itself.
> We delegate behaviour changes to the user / admin of the catalog as opposed
The service _admin_ has little control over whether users create a new
catalog with this config set. They do however have control over whether to
upgrade/downgrade the service.
> forcing all clients to deal with the default value of the new attribute
even if their catalogs do not have to set it.
As @snazy said, `If clients fail on unknown properties, it's a bug in those
client.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
