eric-maynard commented on code in PR #2012:
URL: https://github.com/apache/polaris/pull/2012#discussion_r2208632386
##########
spec/polaris-management-service.yml:
##########
@@ -1056,6 +1056,12 @@ components:
type: string
description: endpoint for STS requests (optional). If not set,
defaults to 'endpoint'.
example: "https://sts.example.com:1234";
+ pathStyleAccess:
+ type: boolean
+ description: >-
+ Whether S3 requests to files in this catalog should use
'path-style addressing for buckets'.
+ Default: false.
Review Comment:
Unfortunately I don't think that's the right decision for the spec. With an
optional boolean you create a sort of ternary type with values `[true, false,
unset]` and there is ambiguity about whether `unset` refers to "really not set"
like in the case of a catalog that predates the change or or whether it refers
to the default. Imagine what would happen if, for example, we changed the
default down the road.
Further, I don't see why `does not alter (old) Polaris catalog behaviour` is
necessarily a merit. We've said that it's not a breaking change. Even if it is,
we don't need to avoid breaking changes at all costs. Let's not compromise the
spec to avoid a non-breaking change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
