Re: [PR] Fix createViewWithCustomMetadataLocation tests for cloudTest task [polaris]

[via GitHub]

snazy commented on code in PR #2405:
URL: https://github.com/apache/polaris/pull/2405#discussion_r2287523223


##########
integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogViewGcpIntegrationTestBase.java:
##########
@@ -19,13 +19,12 @@
 package org.apache.polaris.service.it.test;
 
 import java.util.List;
-import java.util.stream.Stream;
+import org.apache.hadoop.fs.Path;
 import org.apache.polaris.core.admin.model.GcpStorageConfigInfo;
 import org.apache.polaris.core.admin.model.StorageConfigInfo;
-import org.assertj.core.util.Strings;
 
 /** Runs PolarisRestCatalogViewIntegrationTest on GCP. */
-public class PolarisRestCatalogViewGcpIntegrationTest
+public abstract class PolarisRestCatalogViewGcpIntegrationTestBase

Review Comment:
   Similar here
   ```suggestion
   public abstract class PolarisRestCatalogViewGcsIntegrationTestBase
   ```



##########
integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogViewAwsIntegrationTestBase.java:
##########
@@ -20,13 +20,12 @@
 
 import java.util.List;
 import java.util.Optional;
-import java.util.stream.Stream;
+import org.apache.hadoop.fs.Path;

Review Comment:
   Hm, sure, this is just a test, but could we avoid Hadoop dependencies?



##########
integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogViewAwsIntegrationTestBase.java:
##########
@@ -20,13 +20,12 @@
 
 import java.util.List;
 import java.util.Optional;
-import java.util.stream.Stream;
+import org.apache.hadoop.fs.Path;
 import org.apache.polaris.core.admin.model.AwsStorageConfigInfo;
 import org.apache.polaris.core.admin.model.StorageConfigInfo;
-import org.assertj.core.util.Strings;
 
 /** Runs PolarisRestCatalogViewIntegrationTest on AWS. */
-public class PolarisRestCatalogViewAwsIntegrationTest
+public abstract class PolarisRestCatalogViewAwsIntegrationTestBase

Review Comment:
   Since we're renaming this type anyway, let's better use the protocol name, 
not the vendor name.
   
   ```suggestion
   public abstract class PolarisRestCatalogViewS3IntegrationTestBase
   ```



##########
integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogViewAzureIntegrationTestBase.java:
##########
@@ -19,13 +19,12 @@
 package org.apache.polaris.service.it.test;
 
 import java.util.List;
-import java.util.stream.Stream;
+import org.apache.hadoop.fs.Path;
 import org.apache.polaris.core.admin.model.AzureStorageConfigInfo;
 import org.apache.polaris.core.admin.model.StorageConfigInfo;
-import org.assertj.core.util.Strings;
 
 /** Runs PolarisRestCatalogViewIntegrationTest on Azure. */
-public class PolarisRestCatalogViewAzureIntegrationTest
+public abstract class PolarisRestCatalogViewAzureIntegrationTestBase

Review Comment:
   Similar
   ```suggestion
   public abstract class PolarisRestCatalogViewAdlsIntegrationTestBase
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org