snazy commented on code in PR #2405: URL: https://github.com/apache/polaris/pull/2405#discussion_r2287706391
########## integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogViewAwsIntegrationTestBase.java: ########## @@ -20,13 +20,12 @@ import java.util.List; import java.util.Optional; -import java.util.stream.Stream; +import org.apache.hadoop.fs.Path; Review Comment: Argh - the damn `file` URI scheme is so ambiguous (IMHO, because of [multiple representations](https://en.wikipedia.org/wiki/File_URI_scheme) for the same thing, legacy representations, risk of interpreting those wrong). If it's just about eliminating all host related parts, I'd say let's just use a regex to "fix" the paths? Something like ```java protected static final Pattern FILE_LOCATION_PATTERN = Pattern.compile("file:/*(.*)"); protected String fixFileUri(String location) { var m = FILE_LOCATION_PATTERN.matcher(location); return m.matches() ? "file:/" + m.group(1) : location; } ``` WDYT? Would that work? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
