tmater commented on code in PR #2405: URL: https://github.com/apache/polaris/pull/2405#discussion_r2287554035
########## integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogViewAwsIntegrationTestBase.java: ########## @@ -20,13 +20,12 @@ import java.util.List; import java.util.Optional; -import java.util.stream.Stream; +import org.apache.hadoop.fs.Path; import org.apache.polaris.core.admin.model.AwsStorageConfigInfo; import org.apache.polaris.core.admin.model.StorageConfigInfo; -import org.assertj.core.util.Strings; /** Runs PolarisRestCatalogViewIntegrationTest on AWS. */ -public class PolarisRestCatalogViewAwsIntegrationTest +public abstract class PolarisRestCatalogViewAwsIntegrationTestBase Review Comment: Shall I change these 3 (non-view test bases) as well in one go: - PolarisRestCatalogAwsIntegrationTestBase - PolarisRestCatalogAzureIntegrationTestBase - PolarisRestCatalogGcpIntegrationTestBase Also the 6 implementations: - RestCatalogAwsIT - RestCatalogAzureIT - RestCatalogGcpIT - RestCatalogViewAwsIT - RestCatalogViewAzureIT - RestCatalogViewGcpIT ########## integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogViewAwsIntegrationTestBase.java: ########## @@ -20,13 +20,12 @@ import java.util.List; import java.util.Optional; -import java.util.stream.Stream; +import org.apache.hadoop.fs.Path; Review Comment: The idea behind Hadoop Path came because Iceberg does something "funky" with the `metadataFileLocation()` that resembles Hadoop Path behavior: It normalizes the scheme `file:///...` to `file:/...`, but it keeps `s3://...` as `s3://...`. For the assertion later I couldn't use `java.nio.Path` because that normalizes the scheme and creates an incorrect `s3:/...` path. Just dug a bit more, I found a reference to Hadoop Path in Iceberg's [LocationProviders:24](https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/LocationProviders.java#L24), maybe this is how they do it as well, I could not find the exact location where it gets normalized. I’m open to other approaches, but the only solution that came to mind was writing a custom assertion, which I’m also happy with. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
