snazy commented on code in PR #2405: URL: https://github.com/apache/polaris/pull/2405#discussion_r2287678646
########## integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogViewAwsIntegrationTestBase.java: ########## @@ -20,13 +20,12 @@ import java.util.List; import java.util.Optional; -import java.util.stream.Stream; +import org.apache.hadoop.fs.Path; import org.apache.polaris.core.admin.model.AwsStorageConfigInfo; import org.apache.polaris.core.admin.model.StorageConfigInfo; -import org.assertj.core.util.Strings; /** Runs PolarisRestCatalogViewIntegrationTest on AWS. */ -public class PolarisRestCatalogViewAwsIntegrationTest +public abstract class PolarisRestCatalogViewAwsIntegrationTestBase Review Comment: Mean, we support MinIO and a bunch of other S3 compatible systems, not only AWS. Sure, we could argue about GCS or ADLS. However, GCS and ADLS are specific, where a vendor name or "product suite" name are not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
