adutra commented on code in PR #2405: URL: https://github.com/apache/polaris/pull/2405#discussion_r2288106234
########## integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogViewAwsIntegrationTestBase.java: ########## @@ -20,13 +20,12 @@ import java.util.List; import java.util.Optional; -import java.util.stream.Stream; +import org.apache.hadoop.fs.Path; Review Comment: Just FYI In Polaris we have: - `org.apache.polaris.core.storage.StorageLocation` which standardizes fiel URIs to `"file:///` - but `InMemoryStorageIntegration` does the opposite 😅 : https://github.com/apache/polaris/blob/532ee5137d2c41774983d075ea31dcbd2661aa1d/polaris-core/src/main/java/org/apache/polaris/core/storage/InMemoryStorageIntegration.java#L74 ########## integration-tests/src/main/java/org/apache/polaris/service/it/test/PolarisRestCatalogViewAwsIntegrationTestBase.java: ########## @@ -20,13 +20,12 @@ import java.util.List; import java.util.Optional; -import java.util.stream.Stream; +import org.apache.hadoop.fs.Path; Review Comment: Just FYI In Polaris we have: - `org.apache.polaris.core.storage.StorageLocation` which standardizes file URIs to `"file:///` - but `InMemoryStorageIntegration` does the opposite 😅 : https://github.com/apache/polaris/blob/532ee5137d2c41774983d075ea31dcbd2661aa1d/polaris-core/src/main/java/org/apache/polaris/core/storage/InMemoryStorageIntegration.java#L74 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
