cobed95 commented on PR #4945: URL: https://github.com/apache/polaris/pull/4945#issuecomment-5030854814
@adutra I've pushed the follow-ups from the mailing-list discussion: - **Helm `additionalProperties`** ([69009122c](https://github.com/apache/polaris/pull/4945/commits/69009122c)) — replaced the single-purpose `persistence.relationalJdbc.schemaName` with a `persistence.relationalJdbc.additionalProperties` map (default `{currentSchema: POLARIS_SCHEMA}`), rendered as `quarkus.datasource.jdbc.additional-jdbc-properties.<name>`, exactly as you suggested. This keeps the schema selection as the default while leaving the door open for other JDBC driver properties; a unittest covers an extra property rendering alongside the default. - **Docs + Helm fixture alignment** ([eb39400e8](https://github.com/apache/polaris/pull/4945/commits/eb39400e8)) — corrected the admin-tool and production-configuration guides (they still claimed Polaris creates `polaris_schema` at bootstrap) and created the schema in the Helm CI PostgreSQL fixture, so bootstrap works against it with the shipped `currentSchema` default. On the quickstart friction you mentioned: I went with creating the schema at each database-provisioning point (the shared compose assets and the Helm test fixture) rather than adding a manual step to every guide, so the tutorials themselves stay unchanged. Happy to adjust if you'd prefer a different approach there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
