flyrain commented on code in PR #4945: URL: https://github.com/apache/polaris/pull/4945#discussion_r3626702105
########## runtime/defaults/src/main/resources/application.properties: ########## @@ -50,6 +50,12 @@ quarkus.otel.enabled=true #quarkus.mongodb.metrics.enabled=true #quarkus.mongodb.connection-string=mongodb://localhost:27017 quarkus.datasource.db-kind=postgresql +# The database schema holding the Polaris tables for the 'relational-jdbc' persistence type. The +# schema is selected by the JDBC driver on each connection (the PostgreSQL driver's currentSchema +# connection property, also used for CockroachDB). Override this property, or set currentSchema +# directly in the JDBC URL (the URL takes precedence). The schema must exist before Polaris +# connects; creating it is a DBA task requiring elevated privileges. +quarkus.datasource.jdbc.additional-jdbc-properties.currentSchema=POLARIS_SCHEMA Review Comment: Does this(`currentSchema`) only work with PostgreSQL driver? How about other drivers, like MySQL? We will need a different way to inject the schema name, right? ``` quarkus.datasource.jdbc.url=jdbc:mysql://mysql.example.com:3306/polaris_schema ``` I understand that Polaris only supports PostgreSQL style driver now. However, there is a ongoing PR(#4281) to add MySQL support. This approach adds a hard dependency on the driver's behavior. Are we OK with it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
