adutra commented on code in PR #4945:
URL: https://github.com/apache/polaris/pull/4945#discussion_r3663904654
##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/QueryGenerator.java:
##########
@@ -413,9 +399,4 @@ public static PreparedQuery generateOverlapQuery(
null);
return new PreparedQuery(query.sql(), where.parameters());
}
-
- static String getFullyQualifiedTableName(String tableName) {
- // TODO: make schema name configurable.
- return "POLARIS_SCHEMA." + tableName;
- }
Review Comment:
I also think it's best to not deal with schemas in the code.
However it should certainly be possible to log the current schema somewhere;
it should also be possible to put the schema name in the MDC context if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
