singhpk234 commented on code in PR #4945:
URL: https://github.com/apache/polaris/pull/4945#discussion_r3649016173
##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/QueryGenerator.java:
##########
@@ -413,9 +399,4 @@ public static PreparedQuery generateOverlapQuery(
null);
return new PreparedQuery(query.sql(), where.parameters());
}
-
- static String getFullyQualifiedTableName(String tableName) {
- // TODO: make schema name configurable.
- return "POLARIS_SCHEMA." + tableName;
- }
Review Comment:
is it possible to have 2 part identifier still ? can we get the schema and
add this here ?
- i know we are setting this in connection context the schema but this seems
more easy to debug stuff
##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/QueryGenerator.java:
##########
@@ -413,9 +399,4 @@ public static PreparedQuery generateOverlapQuery(
null);
return new PreparedQuery(query.sql(), where.parameters());
}
-
- static String getFullyQualifiedTableName(String tableName) {
- // TODO: make schema name configurable.
- return "POLARIS_SCHEMA." + tableName;
- }
Review Comment:
or to put it in a different way are we logging what is the current_schema
##########
runtime/admin/src/main/resources/application.properties:
##########
@@ -47,6 +47,13 @@ quarkus.mongodb.devservices.enabled=false
# - relational-jdbc - JdbcMetaStoreManagerFactory
# - nosql - NoSQL persistence backend, define the backend type via
'polaris.persistence.nosql.backend'
polaris.persistence.type=relational-jdbc
+# The database schema holding the Polaris tables for the 'relational-jdbc'
persistence type. The
+# schema is selected by the JDBC driver on each connection (the PostgreSQL
driver's currentSchema
+# connection property, also used for CockroachDB) and must match the schema
configured on the
+# running Polaris server. Override this property, or set currentSchema
directly in the JDBC URL
+# (the URL takes precedence). The schema must exist before bootstrapping;
creating it is a DBA
+# task requiring elevated privileges.
+quarkus.datasource.jdbc.additional-jdbc-properties.currentSchema=POLARIS_SCHEMA
Review Comment:
checking this :
https://quarkus.io/guides/datasource#quarkus-agroal_quarkus-datasource-jdbc-additional-jdbc-properties-property-key
is this property supported by all drivers ? or is it just PG / Cockroach
thing ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
