cobed95 commented on PR #4945: URL: https://github.com/apache/polaris/pull/4945#issuecomment-5042375925
**Update: rebased on main + CI fixes** Brought the branch up to date with `main` (`9b9a6c927`) and fixed the test fallout from the schema-agnostic change: - **Test datasources now provision the schema themselves** (`cd827ce96`). Since the persistence layer no longer places tables in a specific schema, tests that stand up a fresh database have to create and select `POLARIS_SCHEMA` — the same DBA step a real deployment performs. The Postgres/CockroachDB test lifecycle managers now `CREATE SCHEMA` after starting the container, and the H2-backed runtime-service profiles create it via the JDBC URL `INIT` and select it with `new-connection-sql` on every connection (H2 ignores the `currentSchema` connection property). This covers the Admin Tool bootstrap tests, the `InMemoryBufferEventListener*` tests, and `JdbcEventsPersistenceTest`. - **Regenerated `values.schema.json`** (`8dcf2df6b`) so the Helm schema check passes — the generated `currentSchema` sub-property under `additionalProperties` was missing. - **MySQL caveat** (per @flyrain's question): `currentSchema` is PostgreSQL/CockroachDB-specific and is silently ignored by MySQL Connector/J (verified against a real MySQL instance); MySQL selects the namespace via the database in the JDBC URL, as #4281 already does. The Helm values now document this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
