aharui commented on a change in pull request #150:
URL: https://github.com/apache/royale-compiler/pull/150#discussion_r429605309
##########
File path: pom.xml
##########
@@ -340,24 +341,6 @@
</executions>
</plugin>
- <!-- This plugin cleans up the jars for anything that might cause
problems for reproducible builds -->
- <!--
- Even if the core maven plugins currently would support doing this
without, we would be required
- to set the line-separator and the Antlr3 plugin crashes if this is set
to something non-default
- -->
- <plugin>
- <groupId>io.github.zlika</groupId>
- <artifactId>reproducible-build-maven-plugin</artifactId>
- <version>0.11</version>
- <executions>
- <execution>
- <goals>
- <goal>strip-jar</goal>
- </goals>
- </execution>
- </executions>
- </plugin>
-
<!-- Plugin to detect problems with JDK incompatibilities -->
Review comment:
One of our requirements is that the binaries built on Windows match
binaries built on Mac. The documentation at
https://maven.apache.org/guides/mini/guide-reproducible-builds.html seems to
warn that it will not change line-endings. The zlika plugin has made it
possible to have Windows and Mac binaries match.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
