hboutemy commented on a change in pull request #150:
URL: https://github.com/apache/royale-compiler/pull/150#discussion_r429751950
##########
File path: pom.xml
##########
@@ -340,24 +341,6 @@
</executions>
</plugin>
- <!-- This plugin cleans up the jars for anything that might cause
problems for reproducible builds -->
- <!--
- Even if the core maven plugins currently would support doing this
without, we would be required
- to set the line-separator and the Antlr3 plugin crashes if this is set
to something non-default
- -->
- <plugin>
- <groupId>io.github.zlika</groupId>
- <artifactId>reproducible-build-maven-plugin</artifactId>
- <version>0.11</version>
- <executions>
- <execution>
- <goals>
- <goal>strip-jar</goal>
- </goals>
- </execution>
- </executions>
- </plugin>
-
<!-- Plugin to detect problems with JDK incompatibilities -->
Review comment:
the result you see on
https://github.com/jvm-repo-rebuild/reproducible-central is done with crlf
tweaking on the rebuilder process: if you want I can configure with normal lf
and you'll see the additionnal issues
or you can build for yourself: it's just `./rebuild.sh
content/org/apache/royale/compiler/royale-compiler-0.9.7.buildspec` with Docker
available on your machine: the advantage is that you'll be able to diffoscope
to see the actual differences
and to see the result without the crlf workaround, edit the spec to replace
`newline=crlf` with `newline=lf`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
