aharui commented on a change in pull request #150:
URL: https://github.com/apache/royale-compiler/pull/150#discussion_r430210059
##########
File path: pom.xml
##########
@@ -340,24 +341,6 @@
</executions>
</plugin>
- <!-- This plugin cleans up the jars for anything that might cause
problems for reproducible builds -->
- <!--
- Even if the core maven plugins currently would support doing this
without, we would be required
- to set the line-separator and the Antlr3 plugin crashes if this is set
to something non-default
- -->
- <plugin>
- <groupId>io.github.zlika</groupId>
- <artifactId>reproducible-build-maven-plugin</artifactId>
- <version>0.11</version>
- <executions>
- <execution>
- <goals>
- <goal>strip-jar</goal>
- </goals>
- </execution>
- </executions>
- </plugin>
-
<!-- Plugin to detect problems with JDK incompatibilities -->
Review comment:
Can you attach the compiler-0.9.7.jar you built from Windows? I think I
followed the instructions and used Docker (for the first time ever). The
results I got had a difference in the META-INF/DEPENDENCIES files and in the
generated code from Antlr and JFlex.
Can I specify a specific version of Java 8 such as 1.8.0_201?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
